Remove unneeded memset calls

Strbuild is safe.

1 files changed, 0 insertions, 12 deletions

diff --git a/src/main.c b/src/main.c
index e896cb8..2b44956 100644
--- a/src/main.c
+++ b/src/main.c
@@ -328,7 +328,6 @@ static int table_next_id(sqlite3 *db, const char *table)
 	int last_id = -1; /* last ID _currently used_ in the table */
 	int rc;
 	char sql[128];
-	memset(sql, 0, sizeof(sql));
 	strbuild(sql, "SELECT MAX(id) FROM %s;", table);
 	rc = sqlite3_exec(db, sql, table_next_id_callback, &last_id, NULL);
 	sqlite3_check(rc, db);
@@ -531,7 +530,6 @@ static void ftag_init(int, char **)
 		exit(EXIT_FAILURE);
 	}
 	char cmd[1024];
-	memset(cmd, 0, sizeof(cmd));
 	strbuild(cmd, "sqlite3 %s < %s",
 		 DATABASE_PATH, FTAG_ROOT "/sql/init.sql");
 	execl("/usr/bin/sh", "/usr/bin/sh", "-c", cmd, NULL);
@@ -558,7 +556,6 @@ static void ftag_list_table(const char *table, const char *col)
 	int rc;
 	rc = sqlite3_open(DATABASE_PATH, &db);
 	sqlite3_check(rc, db);
-	memset(sql, 0, sizeof(sql));
 	strbuild(sql, "SELECT %s FROM %s;", col, table);
 	rc = sqlite3_exec(db, sql, ftag_print, NULL, NULL);
 	sqlite3_check(rc, db);
@@ -675,7 +672,6 @@ ftag_add_one_file(sqlite3 *db, int *next_id, const char *file, uint32_t file_sum
 		extension[0] = '\0';
 	}
 
-	memset(sql, 0, sizeof(sql));
 	strbuild(sql,
 		 "INSERT INTO files VALUES(%d, '%s', '%s', '%s', "
 		 "%ld, %u, '%s')",
@@ -893,7 +889,6 @@ get_id_by_col(sqlite3 *db, const char *table, const char *col, const char *val)
 {
 	int id = -1;
 	char sql[128];
-	memset(sql, 0, sizeof(sql));
 	strbuild(sql, "SELECT id FROM %s WHERE %s = '%s';", table, col, val);
 	int rc = sqlite3_exec(db, sql, get_id_by_col_callback, &id, NULL);
 	sqlite3_check(rc, db);
@@ -917,7 +912,6 @@ static void ftag_file_tag(int argc, char **argv)
 	for (int i = 1; i < argc; i++) {
 		int tag_id = get_id_by_col(db, "tags", "name", argv[i]);
 		printf("%s: debug: tag id is %d\n", __func__, tag_id);
-		memset(sql, 0, sizeof(sql));
 		strbuild(sql, "INSERT INTO file_tags values(%d, %d);",
 			 file_id, tag_id);
 		rc = sqlite3_exec(db, sql, NULL, NULL, NULL);
@@ -989,7 +983,6 @@ static void ftag_query_date(sqlite3 *db,
 		max_len - strlen(sql));
 	assert(strlen(sql) < max_len);
 	if (before_date != 0) {
-		memset(buf, 0, sizeof(buf));
 		strbuild(buf, " WHERE date < %ld", before_date);
 		strncat(sql, buf, max_len - strlen(sql));
 		assert(strlen(sql) < max_len);
@@ -1000,7 +993,6 @@ static void ftag_query_date(sqlite3 *db,
 			strncat(sql, " AND", max_len - strlen(sql));
 		else
 			strncat(sql, " WHERE", max_len - strlen(sql));
-		memset(buf, 0, sizeof(buf));
 		strbuild(buf, " date > %ld", after_date);
 		strncat(sql, buf, max_len - strlen(sql));
 		assert(strlen(sql) < max_len);
@@ -1026,7 +1018,6 @@ static void ftag_query_join(sqlite3 *db,
 			tags, tag_count-1, before_date, after_date);
 	int tag_id = get_id_by_col(db, "tags", "name", tags[tag_count-1]);
 	char suffix[128];
-	memset(suffix, 0, sizeof(suffix));
 	strbuild(suffix, "\t\tON id = file\n\t\tWHERE tag = %d)\n", tag_id);
 	strncat(sql, suffix, max_len - strlen(sql));
 	assert(strlen(sql) < max_len);
@@ -1074,7 +1065,6 @@ static void ftag_query(int argc, char **argv)
 	memset(sql_join, 0, sizeof(sql_join));
 	ftag_query_join(db, sql_join, sizeof(sql_join)-1,
 			tags, tag_count, before_date, after_date);
-	memset(sql, 0, sizeof(sql));
 	strbuild(sql, "SELECT id,canonical_name,full_name FROM (\n%s);\n",
 		 sql_join);
 	printf("%s: debug: SQL query is:\n%s", __func__, sql);
@@ -1115,7 +1105,6 @@ static void ftag_tag_add(int argc, char **argv)
 	rc = sqlite3_open(DATABASE_PATH, &db);
 	sqlite3_check(rc, db);
 
-	memset(sql, 0, sizeof(sql));
 	strbuild(sql, "SELECT name, description FROM tags WHERE name = '%s';",
 		 new_tag_name);
 	rc = sqlite3_exec(db, sql, ftag_tag_check, NULL, NULL);
@@ -1125,7 +1114,6 @@ static void ftag_tag_add(int argc, char **argv)
 	char *new_tag_desc = argv[1];
 	assert(strlen(new_tag_desc) <= 600);
 	sanitize_sql_str(&new_tag_desc);
-	memset(sql, 0, sizeof(sql));
 	strbuild(sql, "INSERT INTO tags VALUES(%d, '%s', '%s');",
 		 next_id, new_tag_name, new_tag_desc);
 	rc = sqlite3_exec(db, sql, NULL, NULL, NULL);